Zodiac issueshttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues2020-04-10T21:24:34Zhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/17steady_cv_ad_closed__Tpzvar takes too long to run2020-04-10T21:24:34ZJames Sutherlandsteady_cv_ad_closed__Tpzvar takes too long to runPlease shorten this test.Please shorten this test.Hang ZhouHang Zhouhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/15Restart2018-10-25T15:20:35ZMike HansenRestartAdd the option of specifying an existing Zodiac output database as input for temperature, pressure, and composition (mass fractions).Add the option of specifying an existing Zodiac output database as input for temperature, pressure, and composition (mass fractions).https://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/14Add regression tests.2018-09-25T17:44:58ZJames SutherlandAdd regression tests.This is really important to preserve the integrity of the code base.
If we must, we can adopt a gold-standard approach. But could we do something like setting up an ignition calculation and spot-checking the temperature at a specific i...This is really important to preserve the integrity of the code base.
If we must, we can adopt a gold-standard approach. But could we do something like setting up an ignition calculation and spot-checking the temperature at a specific iteration count?James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/13Fixed one sign for the matrix transformation2018-02-10T18:03:33ZHang ZhouFixed one sign for the matrix transformation- [x] In the transformation matrix, $`\frac{\partial T}{\partial \rho} = - \frac{e_N}{\rho c_v}`$. The sign should be negative. It is in the file "TransformationMatrixExpressions.h" Line 259.- [x] In the transformation matrix, $`\frac{\partial T}{\partial \rho} = - \frac{e_N}{\rho c_v}`$. The sign should be negative. It is in the file "TransformationMatrixExpressions.h" Line 259.Hang ZhouHang Zhouhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/11Use an expression for tau-mix rather than a value.2017-05-19T09:18:36ZJames SutherlandUse an expression for tau-mix rather than a value.@mahanse made some changes in the matrix assembly stuff that should facilitate this.
There are two (I think) places to pay attention to:
1. [parse_reactor_parameters](src/parser/ParseInputFile.cpp#L185) in [ParseInputFile.cpp](src/p...@mahanse made some changes in the matrix assembly stuff that should facilitate this.
There are two (I think) places to pay attention to:
1. [parse_reactor_parameters](src/parser/ParseInputFile.cpp#L185) in [ParseInputFile.cpp](src/parser/ParseInputFile.cpp). You will need to create the expression for tau_mix there. For now, we can simply support constant expressions. Then the parser won't need to change at all.
1. Where the [matrix is constructed](src/ConstantVolumeMixingConvection.cpp#L259).
Once this is done, we can remove [ReactorEnsembleSpecs](src/parser/ParseInputFile.h#L27) and change [parse_reactor_parameters](src/parser/ParseInputFile.h#L42) to a `void` function.James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/10Autobuild failure2017-05-19T09:18:36ZJames SutherlandAutobuild failureCloning a clean Zodiac repo and letting auto-build go leads to the following error on my mac. Line 147 is `find_package( PoKiTT REQUIRED PATHS ${TPL_DIR}/share )` and Zodiac simply can't find PoKiTT.
Auto-build works fine for me on Pris...Cloning a clean Zodiac repo and letting auto-build go leads to the following error on my mac. Line 147 is `find_package( PoKiTT REQUIRED PATHS ${TPL_DIR}/share )` and Zodiac simply can't find PoKiTT.
Auto-build works fine for me on Prism.
I had Josh try auto-building Zodiac and he arrived at the same issue.
![Screen_Shot_2016-12-06_at_2.11.42_PM](/uploads/dd73ba996d1faefa08030d269783e5c3/Screen_Shot_2016-12-06_at_2.11.42_PM.png)James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/9Move lingering parameters into the input file2017-05-19T09:18:36ZJames SutherlandMove lingering parameters into the input fileThere are a few parameters that should be moved to the input file from where they are currently in `ReactorEnsembleSpecs`
* `tauMix` - this will need to wait until Mike reworks the matrices in Zodiac.
* `h`
* `radius`
* `SoV`
* `Tin...There are a few parameters that should be moved to the input file from where they are currently in `ReactorEnsembleSpecs`
* `tauMix` - this will need to wait until Mike reworks the matrices in Zodiac.
* `h`
* `radius`
* `SoV`
* `Tinf`
Several of these have to do with the convective heat transfer model. Not sure how we want to handle that. We should have a discussion...https://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/6Set zero ghosts by default when building ExprLib.2017-05-19T09:18:36ZJames SutherlandSet zero ghosts by default when building ExprLib.James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/5Use input file rather than command line for problem specification.2017-05-19T09:18:36ZJames SutherlandUse input file rather than command line for problem specification.I personally prefer [yaml](http://www.yaml.org/refcard.html), as it is highly expressive and compact.
Using yaml will require:
* C++ yaml library for reading it in Zodiac. We can use the modified version I have inside the ODT or LBM...I personally prefer [yaml](http://www.yaml.org/refcard.html), as it is highly expressive and compact.
Using yaml will require:
* C++ yaml library for reading it in Zodiac. We can use the modified version I have inside the ODT or LBMS codes.
* [python yaml](http://pyyaml.org/) library for writing it from the web gui.
Things to do:
* [x] Cantera input file specification
* [x] Initialization of primitive variables & parameters through input file. See also issue #7
* [x] Time integrator parameters
* [x] Output fields selection
* [x] lock fields that are requested for output
* [x] allow dualtime and real time output intervals to be specified. Dualtime perhaps should only keep the most recent entries?
* [x] allow override of field names in output
Note that the residence time cannot presently be specified as a parametric variable - only a constant. Mike has some changes in the pipeline to relax this.
James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/4More control over dumping fields to disk2017-05-19T09:18:36ZJames SutherlandMore control over dumping fields to diskThere are a few "modes" we may want to write information in:
1. **time-accurate** mode. In this case, we don't want information over dualtime iterations
1. **steady-state** mode. In this case, we may want information over dualtime it...There are a few "modes" we may want to write information in:
1. **time-accurate** mode. In this case, we don't want information over dualtime iterations
1. **steady-state** mode. In this case, we may want information over dualtime iterations
In addition, we will want the ability to dump information at **specified intervals**, not necessarily each time/dualtime step.James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/2Add examples/tests to Zodiac2017-11-20T14:28:55ZJames SutherlandAdd examples/tests to ZodiacThis may include:
* [x] a few mechanisms
* [x] a few command line examples to run Zodiac. These can be attached as a comment on this issue.
@james can hook these into the CI once we have this ready.This may include:
* [x] a few mechanisms
* [x] a few command line examples to run Zodiac. These can be attached as a comment on this issue.
@james can hook these into the CI once we have this ready.James SutherlandJames Sutherlandhttps://gitlab.multiscale.utah.edu/common/Zodiac/-/issues/1Add documentation for Zodiac2017-11-20T14:28:55ZJames SutherlandAdd documentation for ZodiacWe need a "manual" for Zodiac that should include:
* [x] The equations being solved
* [x] An overview of the solution method, with references to Mike's papers on \Psi-tc
* [x] Summary of input parameters and description of how to use ...We need a "manual" for Zodiac that should include:
* [x] The equations being solved
* [x] An overview of the solution method, with references to Mike's papers on \Psi-tc
* [x] Summary of input parameters and description of how to use zodiac
* [x] Instructions on using the post-processing tools.
We should write this in LaTeX, and then I can probably set up the CI to build the docs automatically.James SutherlandJames Sutherland